Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database middleware pattern #145

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

hoangvvo
Copy link
Owner

Previous we have a pattern where we create a middleware that attaches req.db.

I think this is not a good pattern.This PR changes it so we can access the db using a call like:

  const db = await getMongoDb();

This is also the pattern recommended by Vercel.

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2022

⚠️ No Changeset found

Latest commit: 67efa93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-mongodb-app ✅ Ready (Inspect) Visit Preview Jun 10, 2022 at 7:26PM (UTC)

@hoangvvo hoangvvo merged commit 57edde4 into v2 Jun 10, 2022
@hoangvvo
Copy link
Owner Author

#143 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant